Unverified Commit f89d2cc3 authored by Krishna Yarlagadda's avatar Krishna Yarlagadda Committed by Mark Brown
Browse files

spi: tegra210-quad: use devm call for cdata memory 



Use devm alloc call to allocate memory for spi controller data and
remove free calls from cleanup.

Signed-off-by: default avatarKrishna Yarlagadda <kyarlagadda@nvidia.com>
Link: https://lore.kernel.org/r/1637834152-32093-1-git-send-email-kyarlagadda@nvidia.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f44a29ce

drivers/spi/spi-tegra210-quad.c

+1 −10
Original line number Diff line number Diff line
@@ -877,7 +877,7 @@ static struct tegra_qspi_client_data *tegra_qspi_parse_cdata_dt(struct spi_devic 
	struct tegra_qspi_client_data *cdata;

	struct device_node *slave_np = spi->dev.of_node;



	cdata = kzalloc(sizeof(*cdata), GFP_KERNEL);

	cdata = devm_kzalloc(&spi->dev, sizeof(*cdata), GFP_KERNEL);

	if (!cdata)

		return NULL;
@@ -888,14 +888,6 @@ static struct tegra_qspi_client_data *tegra_qspi_parse_cdata_dt(struct spi_devic 
	return cdata;

}



static void tegra_qspi_cleanup(struct spi_device *spi)

{

	struct tegra_qspi_client_data *cdata = spi->controller_data;



	spi->controller_data = NULL;

	kfree(cdata);

}



static int tegra_qspi_setup(struct spi_device *spi)

{

	struct tegra_qspi *tqspi = spi_master_get_devdata(spi->master);
@@ -1229,7 +1221,6 @@ static int tegra_qspi_probe(struct platform_device *pdev) 
			    SPI_TX_DUAL | SPI_RX_DUAL | SPI_TX_QUAD | SPI_RX_QUAD;

	master->bits_per_word_mask = SPI_BPW_MASK(32) | SPI_BPW_MASK(16) | SPI_BPW_MASK(8);

	master->setup = tegra_qspi_setup;

	master->cleanup = tegra_qspi_cleanup;

	master->transfer_one_message = tegra_qspi_transfer_one_message;

	master->num_chipselect = 1;

	master->auto_runtime_pm = true;