Commit f89a82a8 authored Feb 21, 2021 by Martin Liška Committed by Arnaldo Carvalho de Melo Apr 20, 2021

perf annotate: Add line number like in TUI and source location at EOL



The patch changes the output format in 2 ways:
- line number is displayed for all source lines (matching TUI mode)
- source locations for the hottest lines are printed
   at the line end in order to preserve layout

Before:

     0.00 :   405ef1: inc    %r15
          :            tmpsd * (TD + tmpsd * TDD)));
     0.01 :   405ef4: vfmadd213sd 0x2b9b3(%rip),%xmm0,%xmm3        # 4318b0 <_IO_stdin_used+0x8b0>
          :            tmpsd * (TC +
  eff.c:1811    0.67 :   405efd: vfmadd213sd 0x2b9b2(%rip),%xmm0,%xmm3        # 4318b8 <_IO_stdin_used+0x8b8>
          :            TA + tmpsd * (TB +
     0.35 :   405f06: vfmadd213sd 0x2b9b1(%rip),%xmm0,%xmm3        # 4318c0 <_IO_stdin_used+0x8c0>
          :            dumbo =
  eff.c:1809    1.41 :   405f0f: vfmadd213sd 0x2b9b0(%rip),%xmm0,%xmm3        # 4318c8 <_IO_stdin_used+0x8c8>
          :            sumi -= sj * tmpsd * dij2i * dumbo;
  eff.c:1813    2.58 :   405f18: vmulsd %xmm3,%xmm0,%xmm0
     2.81 :   405f1c: vfnmadd213sd 0x30(%rsp),%xmm1,%xmm0
     3.78 :   405f23: vmovsd %xmm0,0x30(%rsp)
          :            for (k = 0; k < lpears[i] + upears[i]; k++) {
  eff.c:1761    0.90 :   405f29: cmp    %r15d,%r12d

After:

     0.00 :   405ef1: inc    %r15
          : 1812   tmpsd * (TD + tmpsd * TDD)));
     0.01 :   405ef4: vfmadd213sd 0x2b9b3(%rip),%xmm0,%xmm3        # 4318b0 <_IO_stdin_used+0x8b0>
          : 1811   tmpsd * (TC +
     0.67 :   405efd: vfmadd213sd 0x2b9b2(%rip),%xmm0,%xmm3        # 4318b8 <_IO_stdin_used+0x8b8> // eff.c:1811
          : 1810   TA + tmpsd * (TB +
     0.35 :   405f06: vfmadd213sd 0x2b9b1(%rip),%xmm0,%xmm3        # 4318c0 <_IO_stdin_used+0x8c0>
          : 1809   dumbo =
     1.41 :   405f0f: vfmadd213sd 0x2b9b0(%rip),%xmm0,%xmm3        # 4318c8 <_IO_stdin_used+0x8c8> // eff.c:1809
          : 1813   sumi -= sj * tmpsd * dij2i * dumbo;
     2.58 :   405f18: vmulsd %xmm3,%xmm0,%xmm0 // eff.c:1813
     2.81 :   405f1c: vfnmadd213sd 0x30(%rsp),%xmm1,%xmm0
     3.78 :   405f23: vmovsd %xmm0,0x30(%rsp)
          : 1761   for (k = 0; k < lpears[i] + upears[i]; k++) {

Where e.g. '// eff.c:1811' shares the same color as the percentantage
at the line beginning.

Signed-off-by: Martin Liška <mliska@suse.cz>
Link: http://lore.kernel.org/lkml/a0d53f31-f633-5013-c386-a4452391b081@suse.cz


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 537f1e38

tools/perf/util/annotate.c

+14 −16

Original line number	Diff line number	Diff line
		@@ -1368,7 +1368,6 @@ annotation_line__print(struct annotation_line al, struct symbol sym, u64 start
		{
		struct disasm_line *dl = container_of(al, struct disasm_line, al);
		static const char *prev_line;
		static const char *prev_color;

		if (al->offset != -1) {
		double max_percent = 0.0;
		@@ -1407,20 +1406,6 @@ annotation_line__print(struct annotation_line al, struct symbol sym, u64 start

		color = get_percent_color(max_percent);

		/*
		* Also color the filename and line if needed, with
		* the same color than the percentage. Don't print it
		* twice for close colored addr with the same filename:line
		*/
		if (al->path) {
		if (!prev_line \|\| strcmp(prev_line, al->path)
		\|\| color != prev_color) {
		color_fprintf(stdout, color, " %s", al->path);
		prev_line = al->path;
		prev_color = color;
		}
		}

		for (i = 0; i < nr_percent; i++) {
		struct annotation_data *data = &al->data[i];
		double percent;
		@@ -1441,6 +1426,19 @@ annotation_line__print(struct annotation_line al, struct symbol sym, u64 start
		printf(" : ");

		disasm_line__print(dl, start, addr_fmt_width);

		/*
		* Also color the filename and line if needed, with
		* the same color than the percentage. Don't print it
		* twice for close colored addr with the same filename:line
		*/
		if (al->path) {
		if (!prev_line \|\| strcmp(prev_line, al->path)) {
		color_fprintf(stdout, color, " // %s", al->path);
		prev_line = al->path;
		}
		}

		printf("\n");
		} else if (max_lines && printed >= max_lines)
		return 1;
		@@ -1456,7 +1454,7 @@ annotation_line__print(struct annotation_line al, struct symbol sym, u64 start
		if (!*al->line)
		printf(" %*s:\n", width, " ");
		else
		printf(" %s: %s %s\n", width, " ", addr_fmt_width, " ", al->line);
		printf(" %s: %-d %s\n", width, " ", addr_fmt_width, al->line_nr, al->line);
		}

		return 0;