Commit f86a4866 authored by Dan Carpenter's avatar Dan Carpenter Committed by Ilya Dryomov
Browse files

ceph: fix a NULL vs IS_ERR() check when calling ceph_lookup_inode() 



The ceph_lookup_inode() function returns error pointers.  It never
returns NULL.

Fixes: aa87052d ("ceph: fix incorrectly showing the .snap size for stat")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarXiubo Li <xiubli@redhat.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 3a4e894f

fs/ceph/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -2492,7 +2492,7 @@ int ceph_getattr(struct user_namespace *mnt_userns, const struct path *path, 
			struct inode *parent;



			parent = ceph_lookup_inode(sb, ceph_ino(inode));

			if (!parent)

			if (IS_ERR(parent))

				return PTR_ERR(parent);



			pci = ceph_inode(parent);