Commit f8047318 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Joerg Roedel
Browse files

iommu/apple-dart: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230321084125.337021-3-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent a2972cb8

drivers/iommu/apple-dart.c

+2 −4
Original line number Diff line number Diff line
@@ -1150,7 +1150,7 @@ static int apple_dart_probe(struct platform_device *pdev) 
	return ret;

}



static int apple_dart_remove(struct platform_device *pdev)

static void apple_dart_remove(struct platform_device *pdev)

{

	struct apple_dart *dart = platform_get_drvdata(pdev);
@@ -1161,8 +1161,6 @@ static int apple_dart_remove(struct platform_device *pdev) 
	iommu_device_sysfs_remove(&dart->iommu);



	clk_bulk_disable_unprepare(dart->num_clks, dart->clks);



	return 0;

}



static const struct apple_dart_hw apple_dart_hw_t8103 = {
@@ -1296,7 +1294,7 @@ static struct platform_driver apple_dart_driver = { 
		.pm			= pm_sleep_ptr(&apple_dart_pm_ops),

	},

	.probe	= apple_dart_probe,

	.remove	= apple_dart_remove,

	.remove_new = apple_dart_remove,

};



module_platform_driver(apple_dart_driver);