Unverified Commit f8043ef5 authored by Hans de Goede's avatar Hans de Goede Committed by Mark Brown
Browse files

ASoC: Intel: bytcr_rt5640: Use cfg-lineout:2 in the components string 



Use "cfg-lineout:2" in the components string on boards with a lineout
instead of "cfg-lineout:1", this better mirrors the speaker part of
the components string where we use "cfg-spk:1" for devices with a single
speaker and "cfg-spk:2" for stereo speakers.

The lineout is stereo by default, so using ":2" makes more sense, this
way we keep ":1" reserved in case we ever encounter a device with
a mono lineout.

We can make this change without breaking userspace because no kernel
has shipped with "cfg-lineout:1" in the component-string yet; and there
also are no userspace bits (UCM profiles) checking for this yet.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210816114722.107363-1-hdegoede@redhat.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1b5d1d3a

sound/soc/intel/boards/bytcr_rt5640.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1544,7 +1544,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) 
		if (byt_rt5640_quirk & BYT_RT5640_LINEOUT_AS_HP2)

		if (byt_rt5640_quirk & BYT_RT5640_LINEOUT_AS_HP2)

			lineout_string = " cfg-hp2:lineout";

			lineout_string = " cfg-hp2:lineout";

		else

		else

			lineout_string = " cfg-lineout:1";

			lineout_string = " cfg-lineout:2";

	}

	}





	if (byt_rt5640_quirk & BYT_RT5640_HSMIC2_ON_IN1)

	if (byt_rt5640_quirk & BYT_RT5640_HSMIC2_ON_IN1)