Commit f7f9c054 authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Joerg Roedel
Browse files

iommu: Remove iommu_group_get_by_id() 



This is never called.

Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/0-v1-60bbc66d7e92+24-rm_iommu_get_by_id_jgg@nvidia.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent e223864f

drivers/iommu/iommu.c

+0 −29
Original line number Diff line number Diff line
@@ -882,35 +882,6 @@ struct iommu_group *iommu_group_alloc(void) 
}

EXPORT_SYMBOL_GPL(iommu_group_alloc);



struct iommu_group *iommu_group_get_by_id(int id)

{

	struct kobject *group_kobj;

	struct iommu_group *group;

	const char *name;



	if (!iommu_group_kset)

		return NULL;



	name = kasprintf(GFP_KERNEL, "%d", id);

	if (!name)

		return NULL;



	group_kobj = kset_find_obj(iommu_group_kset, name);

	kfree(name);



	if (!group_kobj)

		return NULL;



	group = container_of(group_kobj, struct iommu_group, kobj);

	BUG_ON(group->id != id);



	kobject_get(group->devices_kobj);

	kobject_put(&group->kobj);



	return group;

}

EXPORT_SYMBOL_GPL(iommu_group_get_by_id);



/**

 * iommu_group_get_iommudata - retrieve iommu_data registered for a group

 * @group: the group

include/linux/iommu.h

+0 −6
Original line number Diff line number Diff line
@@ -460,7 +460,6 @@ extern bool iommu_present(struct bus_type *bus); 
extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);

extern bool iommu_group_has_isolated_msi(struct iommu_group *group);

extern struct iommu_domain *iommu_domain_alloc(struct bus_type *bus);

extern struct iommu_group *iommu_group_get_by_id(int id);

extern void iommu_domain_free(struct iommu_domain *domain);

extern int iommu_attach_device(struct iommu_domain *domain,

			       struct device *dev);
@@ -746,11 +745,6 @@ static inline struct iommu_domain *iommu_domain_alloc(struct bus_type *bus) 
	return NULL;

}



static inline struct iommu_group *iommu_group_get_by_id(int id)

{

	return NULL;

}



static inline void iommu_domain_free(struct iommu_domain *domain)

{

}