Commit f77ebdda authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Georgi Djakov
Browse files

interconnect: qcom: osm-l3: fix icc_onecell_data allocation 



This is a struct with a trailing zero-length array of icc_node pointers
but it's allocated as if it were a single array of icc_nodes instead.

Fortunately this overallocates memory rather then allocating less memory
than required.

Fix by replacing devm_kcalloc() with devm_kzalloc() and struct_size()
macro.

Fixes: 5bc9900a ("interconnect: qcom: Add OSM L3 interconnect provider support")
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20230105002221.1416479-2-dmitry.baryshkov@linaro.org


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent fe15c26e

drivers/interconnect/qcom/osm-l3.c

+1 −1
Original line number Diff line number Diff line
@@ -236,7 +236,7 @@ static int qcom_osm_l3_probe(struct platform_device *pdev) 
	qnodes = desc->nodes;

	num_nodes = desc->num_nodes;



	data = devm_kcalloc(&pdev->dev, num_nodes, sizeof(*node), GFP_KERNEL);

	data = devm_kzalloc(&pdev->dev, struct_size(data, nodes, num_nodes), GFP_KERNEL);

	if (!data)

		return -ENOMEM;