Commit f70cc330 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: fix RTC removal 



Since the rtc_register_device, removing an RTC device will end with a
refcount_t: underflow; use-after-free warning since put_device is called
twice in the device tear down path.

Fixes: fdcfd854 ("rtc: rework rtc_register_device() resource management")
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20201205231449.610980-1-alexandre.belloni@bootlin.com
parent ce9af893

drivers/rtc/class.c

+0 −1
Original line number Diff line number Diff line
@@ -335,7 +335,6 @@ static void devm_rtc_unregister_device(void *data) 
	cdev_device_del(&rtc->char_dev, &rtc->dev);

	rtc->ops = NULL;

	mutex_unlock(&rtc->ops_lock);

	put_device(&rtc->dev);

}



static void devm_rtc_release_device(void *res)