Commit f70968f0 authored by Colin Ian King's avatar Colin Ian King Committed by Jason Gunthorpe
Browse files

i40iw: fix null pointer dereference on a null wqe pointer 

Currently the null check for wqe is incorrect and lets a null wqe
be passed to set_64bit_val and this indexes into the null pointer
causing a null pointer dereference.  Fix this by fixing the null
pointer check to return an error if wqe is null.

Link: https://lore.kernel.org/r/20200401224921.405279-1-colin.king@canonical.com


Addresses-Coverity: ("dereference after a null check")
Fixes: 4b34e23f ("i40iw: Report correct firmware version")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 8f3d9f35

drivers/infiniband/hw/i40iw/i40iw_ctrl.c

+1 −1
Original line number Diff line number Diff line
@@ -1046,7 +1046,7 @@ i40iw_sc_query_rdma_features(struct i40iw_sc_cqp *cqp, 
	u64 header;



	wqe = i40iw_sc_cqp_get_next_send_wqe(cqp, scratch);

	if (wqe)

	if (!wqe)

		return I40IW_ERR_RING_FULL;



	set_64bit_val(wqe, 32, feat_mem->pa);