Commit f6d706dd authored by Yang Li's avatar Yang Li Committed by Greg Kroah-Hartman
Browse files

char/mwave: turn tp3780I_Cleanup() into void function 



This function always return '0' and no callers use the return value.
So make it a void function.

This eliminates the following coccicheck warning:
./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval".
Return "0" on line 187

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1615366834-20545-1-git-send-email-yang.lee@linux.alibaba.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c15b334

drivers/char/mwave/tp3780i.c

+1 −5
Original line number Diff line number Diff line
@@ -177,14 +177,10 @@ int tp3780I_InitializeBoardData(THINKPAD_BD_DATA * pBDData) 
	return retval;

}



int tp3780I_Cleanup(THINKPAD_BD_DATA * pBDData)

void tp3780I_Cleanup(THINKPAD_BD_DATA *pBDData)

{

	int retval = 0;



	PRINTK_2(TRACE_TP3780I,

		"tp3780i::tp3780I_Cleanup entry and exit pBDData %p\n", pBDData);



	return retval;

}



int tp3780I_CalcResources(THINKPAD_BD_DATA * pBDData)

drivers/char/mwave/tp3780i.h

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ int tp3780I_DisableDSP(THINKPAD_BD_DATA * pBDData); 
int tp3780I_ResetDSP(THINKPAD_BD_DATA * pBDData);

int tp3780I_StartDSP(THINKPAD_BD_DATA * pBDData);

int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities);

int tp3780I_Cleanup(THINKPAD_BD_DATA * pBDData);

void tp3780I_Cleanup(THINKPAD_BD_DATA *pBDData);

int tp3780I_ReadWriteDspDStore(THINKPAD_BD_DATA * pBDData, unsigned int uOpcode,

                               void __user *pvBuffer, unsigned int uCount,

                               unsigned long ulDSPAddr);