Commit f68fd842 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Wen Zhiwei
Browse files

gpio: rockchip: fix OF node leak in probe() 

stable inclusion
from stable-v6.6.51
commit 9ceae54e65a39d456160fe6dfe1b13a475b88834
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAYRVR

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9ceae54e65a39d456160fe6dfe1b13a475b88834



--------------------------------

[ Upstream commit adad2e460e505a556f5ea6f0dc16fe95e62d5d76 ]

Driver code is leaking OF node reference from of_get_parent() in
probe().

Fixes: 936ee267 ("gpio/rockchip: add driver for rockchip gpio")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Reviewed-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Link: https://lore.kernel.org/r/20240826150832.65657-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarWen Zhiwei <wenzhiwei@kylinos.cn>
parent 87a0694e

drivers/gpio/gpio-rockchip.c

+1 −0
Original line number Diff line number Diff line
@@ -713,6 +713,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev) 
		return -ENODEV;



	pctldev = of_pinctrl_get(pctlnp);

	of_node_put(pctlnp);

	if (!pctldev)

		return -EPROBE_DEFER;