Commit f686e959 authored by Cai Huoqing's avatar Cai Huoqing Committed by David S. Miller
Browse files

ionic: Remove redundant pci_clear_master 



Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
	u16 pci_command;

	pci_read_config_word(dev, PCI_COMMAND, &pci_command);
	if (pci_command & PCI_COMMAND_MASTER) {
		pci_command &= ~PCI_COMMAND_MASTER;
		pci_write_config_word(dev, PCI_COMMAND, pci_command);
	}

	pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.

Signed-off-by: default avatarCai Huoqing <cai.huoqing@linux.dev>
Acked-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2d59af83

drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c

+0 −1
Original line number Diff line number Diff line
@@ -392,7 +392,6 @@ static void ionic_remove(struct pci_dev *pdev) 
	ionic_port_reset(ionic);

	ionic_reset(ionic);

	ionic_dev_teardown(ionic);

	pci_clear_master(pdev);

	ionic_unmap_bars(ionic);

	pci_release_regions(pdev);

	pci_disable_device(pdev);