Unverified Commit f674555e authored by Yu Kuai's avatar Yu Kuai Committed by Robert Foss
Browse files

drm: bridge: cdns-mhdp8546: Fix PM reference leak in 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarRobert Foss <robert.foss@linaro.org>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210531135622.3348252-1-yukuai3@huawei.com
parent ef9e57cd

drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c

+2 −2
Original line number Diff line number Diff line
@@ -2478,9 +2478,9 @@ static int cdns_mhdp_probe(struct platform_device *pdev) 
	clk_prepare_enable(clk);



	pm_runtime_enable(dev);

	ret = pm_runtime_get_sync(dev);

	ret = pm_runtime_resume_and_get(dev);

	if (ret < 0) {

		dev_err(dev, "pm_runtime_get_sync failed\n");

		dev_err(dev, "pm_runtime_resume_and_get failed\n");

		pm_runtime_disable(dev);

		goto clk_disable;

	}