Commit f609bf6b authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Takashi Iwai
Browse files

ALSA: hda/hdmi: Remove some dead code 



These snd_BUG_ON() can never trigger, so just remove them to save a few
LoC.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/91a31341f32d493bcc6c4515178ce0755ac1aa70.1681710069.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 714b2f02

sound/pci/hda/patch_hdmi.c

+4 −8
Original line number Diff line number Diff line
@@ -2093,10 +2093,6 @@ static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo, 
		goto unlock;

	}



	if (snd_BUG_ON(pin_idx < 0)) {

		err = -EINVAL;

		goto unlock;

	}

	per_pin = get_pin(spec, pin_idx);



	/* Verify pin:cvt selections to avoid silent audio after S3.
@@ -2188,13 +2184,13 @@ static int hdmi_pcm_close(struct hda_pcm_stream *hinfo, 
		snd_hda_spdif_ctls_unassign(codec, pcm_idx);

		clear_bit(pcm_idx, &spec->pcm_in_use);

		pin_idx = hinfo_to_pin_index(codec, hinfo);

		/*

		 * In such a case, return 0 to match the behavior in

		 * hdmi_pcm_open()

		 */

		if (pin_idx < 0)

			goto unlock;



		if (snd_BUG_ON(pin_idx < 0)) {

			err = -EINVAL;

			goto unlock;

		}

		per_pin = get_pin(spec, pin_idx);



		if (spec->dyn_pin_out) {