Commit f5f93d7f authored by Michael Kelley's avatar Michael Kelley Committed by Wei Liu
Browse files

HID: hyperv: Correctly access fields declared as __le16 



Add the use of le16_to_cpu() for fields declared as __le16. Because
Hyper-V only runs in Little Endian mode, there's no actual bug.
The change is made in the interest of general correctness in
addition to making sparse happy. No functional change.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarMichael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/1654660177-115463-1-git-send-email-mikelley@microsoft.com


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
parent 245b993d

drivers/hid/hid-hyperv.c

+3 −2
Original line number Diff line number Diff line
@@ -199,7 +199,8 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, 
	if (!input_device->hid_desc)

		goto cleanup;



	input_device->report_desc_size = desc->desc[0].wDescriptorLength;

	input_device->report_desc_size = le16_to_cpu(

					desc->desc[0].wDescriptorLength);

	if (input_device->report_desc_size == 0) {

		input_device->dev_info_status = -EINVAL;

		goto cleanup;
@@ -217,7 +218,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device, 


	memcpy(input_device->report_desc,

	       ((unsigned char *)desc) + desc->bLength,

	       desc->desc[0].wDescriptorLength);

	       le16_to_cpu(desc->desc[0].wDescriptorLength));



	/* Send the ack */

	memset(&ack, 0, sizeof(struct mousevsc_prt_msg));