Commit f5e8e215 authored by Colin Ian King's avatar Colin Ian King Committed by Marcel Holtmann
Browse files

Bluetooth: btrtl: fix incorrect skb allocation failure check 



Currently the check for a failed bt_skb_alloc allocation is incorrectly
checking using IS_ERR and this can lead to a null pointer dereference. Fix
this by checking for a null pointer return using the !skb idiom.

Addresses-Coverity: ("Dereference null return")
Fixes: 1996d9ca ("Bluetooth: btrtl: Ask 8821C to drop old firmware")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 844c79bd

drivers/bluetooth/btrtl.c

+1 −1
Original line number Diff line number Diff line
@@ -581,7 +581,7 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev, 
		cmd[1] = opcode >> 8;



		skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);

		if (IS_ERR(skb))

		if (!skb)

			goto out_free;



		skb_put_data(skb, cmd, sizeof(cmd));