Commit f5dfbfc0 authored Jul 27, 2022 by Nirmoy Das Committed by Matthew Auld Jul 28, 2022

drm/i915: disable pci resize on 32-bit machine



PCI bar resize only works with 64 bit BAR so disable
this on 32-bit machine and resolve below compilation error:

drivers/gpu/drm/i915/gt/intel_region_lmem.c:94:23: error: result of
comparison of constant 4294967296 with expression of type
'resource_size_t' (aka 'unsigned int') is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
                    root_res->start > 0x100000000ull)

Fixes: a91d1a17 ("drm/i915: Add support for LMEM PCIe resizable bar")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Acked-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220727173306.16247-1-nirmoy.das@intel.com

parent a8c18bec

drivers/gpu/drm/i915/gt/intel_region_lmem.c

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -15,6 +15,7 @@
	#include "gt/intel_gt_mcr.h"		#include "gt/intel_gt_mcr.h"
	#include "gt/intel_gt_regs.h"		#include "gt/intel_gt_regs.h"

			#ifdef CONFIG_64BIT
	static void _release_bars(struct pci_dev *pdev)		static void _release_bars(struct pci_dev *pdev)
	{		{
	int resno;		int resno;
	@@ -111,6 +112,9 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
	pci_assign_unassigned_bus_resources(pdev->bus);		pci_assign_unassigned_bus_resources(pdev->bus);
	pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);		pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
	}		}
			#else
			static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
			#endif

	static int		static int
	region_lmem_release(struct intel_memory_region *mem)		region_lmem_release(struct intel_memory_region *mem)