Unverified Commit f5be6239 authored by Marek Vasut's avatar Marek Vasut Committed by Robert Foss
Browse files

drm/bridge: tc358767: Convert to atomic ops 



Use the atomic version of the enable/disable operations to continue the
transition to the atomic API. This will be needed to access the mode
from the atomic state.

Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Tested-by: Lucas Stach <l.stach@pengutronix.de> # In both DPI to eDP and DSI to DPI mode.
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220329085015.39159-5-marex@denx.de
parent a219062b

drivers/gpu/drm/bridge/tc358767.c

+11 −4
Original line number Diff line number Diff line
@@ -1234,7 +1234,9 @@ static int tc_edp_stream_disable(struct tc_data *tc) 
	return 0;

}



static void tc_edp_bridge_enable(struct drm_bridge *bridge)

static void

tc_edp_bridge_atomic_enable(struct drm_bridge *bridge,

			    struct drm_bridge_state *old_bridge_state)

{

	struct tc_data *tc = bridge_to_tc(bridge);

	int ret;
@@ -1259,7 +1261,9 @@ static void tc_edp_bridge_enable(struct drm_bridge *bridge) 
	}

}



static void tc_edp_bridge_disable(struct drm_bridge *bridge)

static void

tc_edp_bridge_atomic_disable(struct drm_bridge *bridge,

			     struct drm_bridge_state *old_bridge_state)

{

	struct tc_data *tc = bridge_to_tc(bridge);

	int ret;
@@ -1459,11 +1463,14 @@ static const struct drm_bridge_funcs tc_edp_bridge_funcs = { 
	.detach = tc_edp_bridge_detach,

	.mode_valid = tc_edp_mode_valid,

	.mode_set = tc_bridge_mode_set,

	.enable = tc_edp_bridge_enable,

	.disable = tc_edp_bridge_disable,

	.atomic_enable = tc_edp_bridge_atomic_enable,

	.atomic_disable = tc_edp_bridge_atomic_disable,

	.mode_fixup = tc_bridge_mode_fixup,

	.detect = tc_bridge_detect,

	.get_edid = tc_get_edid,

	.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,

	.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,

	.atomic_reset = drm_atomic_helper_bridge_reset,

};



static bool tc_readable_reg(struct device *dev, unsigned int reg)