Commit f5946bcc authored by Jeff Layton's avatar Jeff Layton Committed by Ilya Dryomov
Browse files

ceph: tone down loglevel on ceph_mdsc_build_path warning 



When this occurs, it usually means that we raced with a rename, and
there is no need to warn in that case.  Only printk if we pass the
rename sequence check but still ended up with pos < 0.

Either way, this doesn't warrant a KERN_ERR message. Change it to
KERN_WARNING.

Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent a9b4b6be

fs/ceph/mds_client.c

+11 −7
Original line number Diff line number Diff line
@@ -2182,13 +2182,17 @@ char *ceph_mdsc_build_path(struct dentry *dentry, int *plen, u64 *pbase, 
	}

	base = ceph_ino(d_inode(temp));

	rcu_read_unlock();

	if (pos < 0 || read_seqretry(&rename_lock, seq)) {

		pr_err("build_path did not end path lookup where "



	if (read_seqretry(&rename_lock, seq))

		goto retry;



	if (pos < 0) {

		/*

		 * A rename didn't occur, but somehow we didn't end up where

		 * we thought we would. Throw a warning and try again.

		 */

		pr_warn("build_path did not end path lookup where "

			"expected, pos is %d\n", pos);

		/* presumably this is only possible if racing with a

		   rename of one of the parent directories (we can not

		   lock the dentries above us to prevent this, but

		   retrying should be harmless) */

		goto retry;

	}