Commit f5379a01 authored by José Expósito's avatar José Expósito Committed by Jiri Kosina
Browse files

HID: uclogic: Use KUNIT_EXPECT_MEMEQ 



Commit b8a926be ("kunit: Introduce KUNIT_EXPECT_MEMEQ and
KUNIT_EXPECT_MEMNEQ macros") introduced a new macro to compare blocks of
memory and, if the test fails, print the result in a human friendly
format. For example, this is the output of a test failure:

 Expected res == params->expected, but
     res ==
      01  02  aa  00  00  00  03  bb  00 <00> 00  04  05
     params->expected ==
      01  02  aa  00  00  00  03  bb  00 <01> 00  04  05

Use this new macro to replace KUNIT_EXPECT_EQ + memcmp.

Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Reviewed-by: default avatarMaíra Canal <mairacanal@riseup.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 9266a881

drivers/hid/hid-uclogic-rdesc-test.c

+1 −2
Original line number Diff line number Diff line
@@ -197,8 +197,7 @@ static void hid_test_uclogic_template(struct kunit *test) 
					   params->param_list,

					   params->param_num);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, res);

	KUNIT_EXPECT_EQ(test, 0,

			memcmp(res, params->expected, params->template_size));

	KUNIT_EXPECT_MEMEQ(test, res, params->expected, params->template_size);

	kfree(res);

}