Commit f53510e8 authored by Mariusz Kozlowski's avatar Mariusz Kozlowski Committed by Greg Kroah-Hartman
Browse files

usb: legousbtower free kill urb cleanup 



Hello,

- usb_free_urb() cleanup
- usb_kill_urb() cleanup

Signed-off-by: default avatarMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2891a51c

drivers/usb/misc/legousbtower.c

+5 −13
Original line number Diff line number Diff line
@@ -317,12 +317,8 @@ static inline void tower_delete (struct lego_usb_tower *dev) 
	tower_abort_transfers (dev);



	/* free data structures */

	if (dev->interrupt_in_urb != NULL) {

	usb_free_urb(dev->interrupt_in_urb);

	}

	if (dev->interrupt_out_urb != NULL) {

	usb_free_urb(dev->interrupt_out_urb);

	}

	kfree (dev->read_buffer);

	kfree (dev->interrupt_in_buffer);

	kfree (dev->interrupt_out_buffer);
@@ -502,15 +498,11 @@ static void tower_abort_transfers (struct lego_usb_tower *dev) 
	if (dev->interrupt_in_running) {

		dev->interrupt_in_running = 0;

		mb();

		if (dev->interrupt_in_urb != NULL && dev->udev) {

		if (dev->udev)

			usb_kill_urb (dev->interrupt_in_urb);

	}

	}

	if (dev->interrupt_out_busy) {

		if (dev->interrupt_out_urb != NULL && dev->udev) {

	if (dev->interrupt_out_busy && dev->udev)

		usb_kill_urb(dev->interrupt_out_urb);

		}

	}



exit:

	dbg(2, "%s: leave", __FUNCTION__);