Commit f5201f87 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix duplicate wq_create_version check 

During code reviews duplicate code sections were found to determine the WQ
Create version.  The duplication was potentially overriding logic that
validated page size.

Link: https://lore.kernel.org/r/20201020202719.54726-6-james.smart@broadcom.com


Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7cbef585

drivers/scsi/lpfc/lpfc_sli.c

+0 −6
Original line number Diff line number Diff line
@@ -15893,12 +15893,6 @@ lpfc_wq_create(struct lpfc_hba *phba, struct lpfc_queue *wq, 
	else

		wq_create_version = LPFC_Q_CREATE_VERSION_0;

















	if (phba->sli4_hba.pc_sli4_params.wqsize & LPFC_WQ_SZ128_SUPPORT)









		wq_create_version = LPFC_Q_CREATE_VERSION_1;









	else









		wq_create_version = LPFC_Q_CREATE_VERSION_0;

















	switch (wq_create_version) {









	case LPFC_Q_CREATE_VERSION_1:









		bf_set(lpfc_mbx_wq_create_wqe_count, &wq_create->u.request_1,