Commit f5136877 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

selftests: router_bridge_vlan: Set vlan_default_pvid 0 on the bridge 



When everything is configured, VLAN membership on the bridge in this
selftest are as follows:

    # bridge vlan show
    port              vlan-id
    swp2              1 PVID Egress Untagged
                      555
    br1               1 Egress Untagged
                      555 PVID Egress Untagged

Note that it is possible for untagged traffic to just flow through as VLAN
1, instead of using VLAN 555 as intended by the test. This configuration
seems too close to "works by accident", and it would be better to just shut
out VLAN 1 altogether.

To that end, configure vlan_default_pvid of 0:

    # bridge vlan show
    port              vlan-id
    swp2              555
    br1               555 PVID Egress Untagged

Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarAmit Cohen <amcohen@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 812de4df

tools/testing/selftests/net/forwarding/router_bridge_vlan.sh

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ h2_destroy() 


router_create()

{

	ip link add name br1 type bridge vlan_filtering 1

	ip link add name br1 type bridge vlan_filtering 1 vlan_default_pvid 0

	ip link set dev br1 up



	ip link set dev $swp1 master br1