Commit f4f82c52 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

scsi: iscsi_tcp: restrict to TCP sockets 



Nothing prevents iscsi_sw_tcp_conn_bind() to receive file descriptor
pointing to non TCP socket (af_unix for example).

Return -EINVAL if this is attempted, instead of crashing the kernel.

Fixes: 7ba24713 ("[SCSI] open-iscsi/linux-iscsi-5 Initiator: Initiator code")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Lee Duncan <lduncan@suse.com>
Cc: Chris Leech <cleech@redhat.com>
Cc: Mike Christie <michael.christie@oracle.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: open-iscsi@googlegroups.com
Cc: linux-scsi@vger.kernel.org
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0113d9c9

drivers/scsi/iscsi_tcp.c

+4 −0
Original line number Diff line number Diff line
@@ -724,6 +724,10 @@ iscsi_sw_tcp_conn_bind(struct iscsi_cls_session *cls_session, 
		return -EEXIST;

	}



	err = -EINVAL;

	if (!sk_is_tcp(sock->sk))

		goto free_socket;



	err = iscsi_conn_bind(cls_session, cls_conn, is_leading);

	if (err)

		goto free_socket;