Commit f4d1d17e authored by Miquel Raynal's avatar Miquel Raynal Committed by Greg Kroah-Hartman
Browse files

nvmem: core: Create all cells before adding the nvmem device 



Let's pack all the cells creation in one place, so they are all created
before we add the nvmem device.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: default avatarMichael Walle <michael@walle.cc>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20230823132744.350618-20-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1006ebe9

drivers/nvmem/core.c

+5 −5
Original line number Diff line number Diff line
@@ -997,17 +997,17 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) 
	if (rval)

		goto err_remove_cells;



	dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name);



	rval = device_add(&nvmem->dev);

	rval = nvmem_add_cells_from_fixed_layout(nvmem);

	if (rval)

		goto err_remove_cells;



	rval = nvmem_add_cells_from_fixed_layout(nvmem);

	rval = nvmem_add_cells_from_layout(nvmem);

	if (rval)

		goto err_remove_cells;



	rval = nvmem_add_cells_from_layout(nvmem);

	dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name);



	rval = device_add(&nvmem->dev);

	if (rval)

		goto err_remove_cells;