Commit f4916649 authored by Shyam Prasad N's avatar Shyam Prasad N Committed by Steve French
Browse files

cifs: detect dead connections only when echoes are enabled. 



We can detect server unresponsiveness only if echoes are enabled.
Echoes can be disabled under two scenarios:
1. The connection is low on credits, so we've disabled echoes/oplocks.
2. The connection has not seen any request till now (other than
negotiate/sess-setup), which is when we enable these two, based on
the credits available.

So this fix will check for dead connection, only when echo is enabled.

Signed-off-by: default avatarShyam Prasad N <sprasad@microsoft.com>
CC: <stable@vger.kernel.org> # v5.8+
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 7ba3d1cd

fs/cifs/connect.c

+1 −0
Original line number Diff line number Diff line
@@ -476,6 +476,7 @@ server_unresponsive(struct TCP_Server_Info *server) 
	 */

	if ((server->tcpStatus == CifsGood ||

	    server->tcpStatus == CifsNeedNegotiate) &&

	    (!server->ops->can_echo || server->ops->can_echo(server)) &&

	    time_after(jiffies, server->lstrp + 3 * server->echo_interval)) {

		cifs_server_dbg(VFS, "has not responded in %lu seconds. Reconnecting...\n",

			 (3 * server->echo_interval) / HZ);