Unverified Commit f47d6140 authored by Alexander Stein's avatar Alexander Stein Committed by Robert Foss
Browse files

drm/bridge: tc358767: Switch to devm MIPI-DSI helpers 



DSI device registering and attaching needs to be undone upon
deregistration. This fixes module unload/load.

Fixes: bbfd3190 ("drm/bridge: tc358767: Add DSI-to-DPI mode support")
Signed-off-by: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230517122107.1766673-1-alexander.stein@ew.tq-group.com
parent 1ad79759

drivers/gpu/drm/bridge/tc358767.c

+2 −2
Original line number Diff line number Diff line
@@ -1890,7 +1890,7 @@ static int tc_mipi_dsi_host_attach(struct tc_data *tc) 
	if (dsi_lanes < 0)

		return dsi_lanes;



	dsi = mipi_dsi_device_register_full(host, &info);

	dsi = devm_mipi_dsi_device_register_full(dev, host, &info);

	if (IS_ERR(dsi))

		return dev_err_probe(dev, PTR_ERR(dsi),

				     "failed to create dsi device\n");
@@ -1901,7 +1901,7 @@ static int tc_mipi_dsi_host_attach(struct tc_data *tc) 
	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |

			  MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;



	ret = mipi_dsi_attach(dsi);

	ret = devm_mipi_dsi_attach(dev, dsi);

	if (ret < 0) {

		dev_err(dev, "failed to attach dsi to host: %d\n", ret);

		return ret;