Commit f4470dbf authored by Liang He's avatar Liang He Committed by Heiko Stuebner
Browse files

ARM: rockchip: Add missing of_node_put() in rockchip_suspend_init() 



In rockchip_suspend_init(), of_find_matching_node_and_match() will
return a node pointer with refcount incremented. We should use
of_node_put() in fail path or when it is not used anymore.

Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220616021713.3973472-1-windhl@126.com


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent f2906aa8

arch/arm/mach-rockchip/pm.c

+5 −2
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ void __init rockchip_suspend_init(void) 
					     &match);

	if (!match) {

		pr_err("Failed to find PMU node\n");

		return;

		goto out_put;

	}

	pm_data = (struct rockchip_pm_data *) match->data;
@@ -320,9 +320,12 @@ void __init rockchip_suspend_init(void) 


		if (ret) {

			pr_err("%s: matches init error %d\n", __func__, ret);

			return;

			goto out_put;

		}

	}



	suspend_set_ops(pm_data->ops);



out_put:

	of_node_put(np);

}