Commit f4409a23 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher
Browse files

drm/amdgpu: unlock on error in gfx_v9_4_3_kiq_resume() 



Smatch complains that we need to drop this lock before returning.

    drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:1838 gfx_v9_4_3_kiq_resume()
    warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'.

Fixes: 86301129 ("drm/amdgpu: split gc v9_4_3 functionality from gc v9_0")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7a6a2e59

drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c

+3 −1
Original line number Diff line number Diff line
@@ -1824,8 +1824,10 @@ static int gfx_v9_4_3_kiq_resume(struct amdgpu_device *adev, int xcc_id) 
		return r;



	r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&ring->mqd_ptr);

	if (unlikely(r != 0))

	if (unlikely(r != 0)) {

		amdgpu_bo_unreserve(ring->mqd_obj);

		return r;

	}



	gfx_v9_4_3_kiq_init_queue(ring, xcc_id);

	amdgpu_bo_kunmap(ring->mqd_obj);