Commit f43ec25a authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Inform too slow responses 



For the sake of debugging, show each response that took too long time
and its corresponding last verb.  Since such an error happens in
series once when started, use the ratelimited variant for suppressing
the flood.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 533d7647

sound/pci/hda/hda_controller.c

+11 −2
Original line number Diff line number Diff line
@@ -789,6 +789,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, 
	unsigned long timeout;

	unsigned long loopcounter;

	int do_poll = 0;

	bool warned = false;



 again:

	timeout = jiffies + msecs_to_jiffies(1000);
@@ -808,9 +809,17 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, 
		spin_unlock_irq(&bus->reg_lock);

		if (time_after(jiffies, timeout))

			break;

		if (hbus->needs_damn_long_delay || loopcounter > 3000)

#define LOOP_COUNT_MAX	3000

		if (hbus->needs_damn_long_delay ||

		    loopcounter > LOOP_COUNT_MAX) {

			if (loopcounter > LOOP_COUNT_MAX && !warned) {

				dev_dbg_ratelimited(chip->card->dev,

						    "too slow response, last cmd=%#08x\n",

						    bus->last_cmd[addr]);

				warned = true;

			}

			msleep(2); /* temporary workaround */

		else {

		} else {

			udelay(10);

			cond_resched();

		}