Commit f43837f4 authored by Steven Lee's avatar Steven Lee Committed by Bartosz Golaszewski
Browse files

gpio: gpio-aspeed-sgpio: Return error if ngpios is not multiple of 8. 



Add an else-if condition in the probe function to check whether ngpios is
multiple of 8.
Per AST datasheet, numbers of available serial GPIO pins in Serial GPIO
Configuration Register must be n bytes. For instance, if n = 1, it means
AST SoC supports 8 GPIO pins.

Signed-off-by: default avatarSteven Lee <steven_lee@aspeedtech.com>
Reviewed-by: default avatarAndrew Jeffery <andrew@aj.id.au>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 1f857b67

drivers/gpio/gpio-aspeed-sgpio.c

+4 −0
Original line number Diff line number Diff line
@@ -537,6 +537,10 @@ static int __init aspeed_sgpio_probe(struct platform_device *pdev) 
	if (rc < 0) {

		dev_err(&pdev->dev, "Could not read ngpios property\n");

		return -EINVAL;

	} else if (nr_gpios % 8) {

		dev_err(&pdev->dev, "Number of GPIOs not multiple of 8: %d\n",

			nr_gpios);

		return -EINVAL;

	}



	rc = device_property_read_u32(&pdev->dev, "bus-frequency", &sgpio_freq);