Commit f40c064e authored by Peilin Ye's avatar Peilin Ye Committed by David S. Miller
Browse files

ip6_gre: Avoid updating tunnel->tun_hlen in __gre6_xmit() 



Do not update tunnel->tun_hlen in data plane code.  Use a local variable
instead, just like "tunnel_hlen" in net/ipv4/ip_gre.c:gre_fb_xmit().

Co-developed-by: default avatarCong Wang <cong.wang@bytedance.com>
Signed-off-by: default avatarCong Wang <cong.wang@bytedance.com>
Signed-off-by: default avatarPeilin Ye <peilin.ye@bytedance.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 226c6024

net/ipv6/ip6_gre.c

+3 −2
Original line number Diff line number Diff line
@@ -743,6 +743,7 @@ static netdev_tx_t __gre6_xmit(struct sk_buff *skb, 
		struct ip_tunnel_info *tun_info;

		const struct ip_tunnel_key *key;

		__be16 flags;

		int tun_hlen;



		tun_info = skb_tunnel_info_txcheck(skb);

		if (IS_ERR(tun_info) ||
@@ -760,9 +761,9 @@ static netdev_tx_t __gre6_xmit(struct sk_buff *skb, 
		dsfield = key->tos;

		flags = key->tun_flags &

			(TUNNEL_CSUM | TUNNEL_KEY | TUNNEL_SEQ);

		tunnel->tun_hlen = gre_calc_hlen(flags);

		tun_hlen = gre_calc_hlen(flags);



		gre_build_header(skb, tunnel->tun_hlen,

		gre_build_header(skb, tun_hlen,

				 flags, protocol,

				 tunnel_id_to_key32(tun_info->key.tun_id),

				 (flags & TUNNEL_SEQ) ? htonl(tunnel->o_seqno++)