Commit f3f07ae4 authored by Borislav Petkov's avatar Borislav Petkov
Browse files

x86/umip: Downgrade warning messages to debug loglevel 



After four years in the wild, those have not fullfilled their
initial purpose of pushing people to fix their software to not use
UMIP-emulated instructions, and to warn users about the degraded
emulation performance.

Yet, the only thing that "degrades" performance is overflowing dmesg
with those:

  [Di Sep  7 00:24:05 2021] umip_printk: 1345 callbacks suppressed
  [Di Sep  7 00:24:05 2021] umip: someapp.exe[29231] ip:14064cdba sp:11b7c0: SIDT instruction cannot be used by applications.
  [Di Sep  7 00:24:05 2021] umip: someapp.exe[29231] ip:14064cdba sp:11b7c0: For now, expensive software emulation returns the result.
  ...
  [Di Sep  7 00:26:06 2021] umip_printk: 2227 callbacks suppressed
  [Di Sep  7 00:26:06 2021] umip: someapp.exe[29231] ip:14064cdba sp:11b940: SIDT instruction cannot be used by applications.

and users don't really care about that - they just want to play their
games in wine.

So convert those to debug loglevel - in case someone is still interested
in them, someone can boot with "debug" on the kernel cmdline.

Reported-by: default avatarMarcus Rückert <mrueckert@suse.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Reviewed-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Link: https://lkml.kernel.org/r/20210907200454.30458-1-bp@alien8.de
parent 05075036

arch/x86/kernel/umip.c

+4 −4
Original line number Diff line number Diff line
@@ -92,8 +92,8 @@ static const char * const umip_insns[5] = { 


#define umip_pr_err(regs, fmt, ...) \

	umip_printk(regs, KERN_ERR, fmt, ##__VA_ARGS__)

#define umip_pr_warn(regs, fmt, ...) \

	umip_printk(regs, KERN_WARNING, fmt,  ##__VA_ARGS__)

#define umip_pr_debug(regs, fmt, ...) \

	umip_printk(regs, KERN_DEBUG, fmt,  ##__VA_ARGS__)



/**

 * umip_printk() - Print a rate-limited message
@@ -361,10 +361,10 @@ bool fixup_umip_exception(struct pt_regs *regs) 
	if (umip_inst < 0)

		return false;



	umip_pr_warn(regs, "%s instruction cannot be used by applications.\n",

	umip_pr_debug(regs, "%s instruction cannot be used by applications.\n",

			umip_insns[umip_inst]);



	umip_pr_warn(regs, "For now, expensive software emulation returns the result.\n");

	umip_pr_debug(regs, "For now, expensive software emulation returns the result.\n");



	if (emulate_umip_insn(&insn, umip_inst, dummy_data, &dummy_data_size,

			      user_64bit_mode(regs)))