Commit f3506eee authored by Andreas Gruenbacher's avatar Andreas Gruenbacher
Browse files

gfs2: Fix length of holes reported at end-of-file 



Fix the length of holes reported at the end of a file: the length is
relative to the beginning of the extent, not the seek position which is
rounded down to the filesystem block size.

This bug went unnoticed for some time, but is now caught by the
following assertion in iomap_iter_done():

  WARN_ON_ONCE(iter->iomap.offset + iter->iomap.length <= iter->pos)

Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 49462e2b

fs/gfs2/bmap.c

+1 −1
Original line number Diff line number Diff line
@@ -940,7 +940,7 @@ static int __gfs2_iomap_get(struct inode *inode, loff_t pos, loff_t length, 
		else if (height == ip->i_height)

			ret = gfs2_hole_size(inode, lblock, len, mp, iomap);

		else

			iomap->length = size - pos;

			iomap->length = size - iomap->offset;

	} else if (flags & IOMAP_WRITE) {

		u64 alloc_size;