Commit f326ea63 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: class: fix slab-use-after-free Read in class_register() 



Syzbot found that we had forgotten to unregister the lock_class_key when
using it in commit dcfbb67e ("driver core: class: use lock_class_key
already present in struct subsys_private") so fix that up and correctly
release it when done.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Reported-and-tested-by: default avatar <syzbot+41d665317c811d4d88aa@syzkaller.appspotmail.com>
Fixes: dcfbb67e ("driver core: class: use lock_class_key already present in struct subsys_private")
Link: https://lore.kernel.org/r/2023040126-blandness-duckling-bd55@gregkh


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 980c0561

drivers/base/class.c

+1 −0
Original line number Diff line number Diff line
@@ -103,6 +103,7 @@ static void class_release(struct kobject *kobj) 
		pr_debug("class '%s' does not have a release() function, "

			 "be careful\n", class->name);



	lockdep_unregister_key(&cp->lock_key);

	kfree(cp);

}