Commit f32404ae authored by Johannes Berg's avatar Johannes Berg Committed by Jakub Kicinski
Browse files

net: move net_unlink_todo() out of the header 



There's no reason for this to be in netdevice.h, it's all
just used in dev.c. Also make it no longer inline and let
the compiler decide to do that by itself.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Link: https://lore.kernel.org/r/20220325225023.f49b9056fe1c.I6b901a2df00000837a9bd251a8dd259bd23f5ded@changeid


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6da69b1d

include/linux/netdevice.h

+0 −10
Original line number Diff line number Diff line
@@ -4601,16 +4601,6 @@ bool netdev_has_upper_dev(struct net_device *dev, struct net_device *upper_dev); 
struct net_device *netdev_upper_get_next_dev_rcu(struct net_device *dev,

						     struct list_head **iter);



#ifdef CONFIG_LOCKDEP

static LIST_HEAD(net_unlink_list);



static inline void net_unlink_todo(struct net_device *dev)

{

	if (list_empty(&dev->unlink_list))

		list_add_tail(&dev->unlink_list, &net_unlink_list);

}

#endif



/* iterate through upper list, must be called under RCU read lock */

#define netdev_for_each_upper_dev_rcu(dev, updev, iter) \

	for (iter = &(dev)->adj_list.upper, \

net/core/dev.c

+10 −0
Original line number Diff line number Diff line
@@ -7193,6 +7193,16 @@ static int __netdev_update_upper_level(struct net_device *dev, 
	return 0;

}



#ifdef CONFIG_LOCKDEP

static LIST_HEAD(net_unlink_list);



static void net_unlink_todo(struct net_device *dev)

{

	if (list_empty(&dev->unlink_list))

		list_add_tail(&dev->unlink_list, &net_unlink_list);

}

#endif



static int __netdev_update_lower_level(struct net_device *dev,

				       struct netdev_nested_priv *priv)

{