Commit f3167dc1 authored by Gustavo Pimentel's avatar Gustavo Pimentel Committed by Vinod Koul
Browse files

dmaengine: dw-edma: Reorder variables to keep consistency 



In the driver code structure, I tried to keep the code style consistency
by writing the write channels instructions first, and then follow by the
read channels instructions, mimicking the hardware implementation.

However, this code style failed in some cases. This patch fixes that and
no functional changes are expected.

Signed-off-by: default avatarGustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/9bd1f86f19df8bb5de502fb85a0c5dc07978a9ba.1613674948.git.gustavo.pimentel@synopsys.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 16b90dd9

drivers/dma/dw-edma/dw-edma-pcie.c

+5 −5
Original line number Diff line number Diff line
@@ -20,8 +20,8 @@ 
#define DW_PCIE_VSEC_DMA_ID			0x6

#define DW_PCIE_VSEC_DMA_BAR			GENMASK(10, 8)

#define DW_PCIE_VSEC_DMA_MAP			GENMASK(2, 0)

#define DW_PCIE_VSEC_DMA_RD_CH			GENMASK(25, 16)

#define DW_PCIE_VSEC_DMA_WR_CH			GENMASK(9, 0)

#define DW_PCIE_VSEC_DMA_RD_CH			GENMASK(25, 16)



struct dw_edma_pcie_data {

	/* eDMA registers location */
@@ -39,8 +39,8 @@ struct dw_edma_pcie_data { 
	/* Other */

	enum dw_edma_map_format		mf;

	u8				irqs;

	u16				rd_ch_cnt;

	u16				wr_ch_cnt;

	u16				rd_ch_cnt;

};



static const struct dw_edma_pcie_data snps_edda_data = {
@@ -59,8 +59,8 @@ static const struct dw_edma_pcie_data snps_edda_data = { 
	/* Other */

	.mf				= EDMA_MF_EDMA_UNROLL,

	.irqs				= 1,

	.rd_ch_cnt			= 0,

	.wr_ch_cnt			= 0,

	.rd_ch_cnt			= 0,

};



static int dw_edma_pcie_irq_vector(struct device *dev, unsigned int nr)
@@ -101,8 +101,8 @@ static void dw_edma_pcie_get_vsec_dma_data(struct pci_dev *pdev, 
	pdata->rg_bar = FIELD_GET(DW_PCIE_VSEC_DMA_BAR, val);



	pci_read_config_dword(pdev, vsec + 0xc, &val);

	pdata->rd_ch_cnt = FIELD_GET(DW_PCIE_VSEC_DMA_RD_CH, val);

	pdata->wr_ch_cnt = FIELD_GET(DW_PCIE_VSEC_DMA_WR_CH, val);

	pdata->rd_ch_cnt = FIELD_GET(DW_PCIE_VSEC_DMA_RD_CH, val);



	pci_read_config_dword(pdev, vsec + 0x14, &val);

	off = val;
@@ -218,8 +218,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, 
	dw->mf = vsec_data.mf;

	dw->nr_irqs = nr_irqs;

	dw->ops = &dw_edma_pcie_core_ops;

	dw->rd_ch_cnt = vsec_data.rd_ch_cnt;

	dw->wr_ch_cnt = vsec_data.wr_ch_cnt;

	dw->rd_ch_cnt = vsec_data.rd_ch_cnt;



	/* Debug info */

	if (dw->mf == EDMA_MF_EDMA_LEGACY)