Commit f30741cd authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Takashi Iwai
Browse files

ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 

Commit 5aec9891 ("ALSA: hda/realtek - ALC236 headset MIC recording
issue") is to solve recording issue met on AL236, by matching codec
variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.

This match can be too broad and Mi Notebook Pro 2020 is broken by the
patch.

Instead, use codec ID to be narrow down the scope, in order to make
ALC256 unaffected.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484


Fixes: 5aec9891 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20220330061335.1015533-1-kai.heng.feng@canonical.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5e2baa04

sound/pci/hda/patch_realtek.c

+2 −2
Original line number Diff line number Diff line
@@ -3617,8 +3617,8 @@ static void alc256_shutup(struct hda_codec *codec) 
	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly

	 * when booting with headset plugged. So skip setting it for the codec alc257

	 */

	if (spec->codec_variant != ALC269_TYPE_ALC257 &&

	    spec->codec_variant != ALC269_TYPE_ALC256)

	if (codec->core.vendor_id != 0x10ec0236 &&

	    codec->core.vendor_id != 0x10ec0257)

		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);



	if (!spec->no_shutup_pins)