Commit f2fb4fe6 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven
Browse files

clk: renesas: Zero init clk_init_data



As clk_core_populate_parent_map() checks clk_init_data.num_parents
first, and checks clk_init_data.parent_names[] before
clk_init_data.parent_data[] and clk_init_data.parent_hws[], leaving the
latter uninitialized doesn't do harm for now.  However, it is better to
play it safe, and initialize all clk_init_data structures to zeroes, to
avoid any current and future members containing uninitialized data.

Remove a few explicit zero initializers, which are now superfluous.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarStephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20210326105434.1574796-1-geert+renesas@glider.be
parent dbb397cc
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ struct clk * __init cpg_div6_register(const char *name,
				      struct raw_notifier_head *notifiers)
{
	unsigned int valid_parents;
	struct clk_init_data init;
	struct clk_init_data init = {};
	struct div6_clock *clock;
	struct clk *clk;
	unsigned int i;
@@ -267,7 +267,6 @@ struct clk * __init cpg_div6_register(const char *name,
	/* Register the clock. */
	init.name = name;
	init.ops = &cpg_div6_clock_ops;
	init.flags = 0;
	init.parent_names = parent_names;
	init.num_parents = valid_parents;

+1 −1
Original line number Diff line number Diff line
@@ -150,7 +150,7 @@ static struct clk * __init cpg_mstp_clock_register(const char *name,
	const char *parent_name, unsigned int index,
	struct mstp_clock_group *group)
{
	struct clk_init_data init;
	struct clk_init_data init = {};
	struct mstp_clock *clock;
	struct clk *clk;

+4 −4
Original line number Diff line number Diff line
@@ -504,7 +504,7 @@ r9a06g032_register_gate(struct r9a06g032_priv *clocks,
{
	struct clk *clk;
	struct r9a06g032_clk_gate *g;
	struct clk_init_data init;
	struct clk_init_data init = {};

	g = kzalloc(sizeof(*g), GFP_KERNEL);
	if (!g)
@@ -674,7 +674,7 @@ r9a06g032_register_div(struct r9a06g032_priv *clocks,
{
	struct r9a06g032_clk_div *div;
	struct clk *clk;
	struct clk_init_data init;
	struct clk_init_data init = {};
	unsigned int i;

	div = kzalloc(sizeof(*div), GFP_KERNEL);
@@ -758,7 +758,7 @@ r9a06g032_register_bitsel(struct r9a06g032_priv *clocks,
{
	struct clk *clk;
	struct r9a06g032_clk_bitsel *g;
	struct clk_init_data init;
	struct clk_init_data init = {};
	const char *names[2];

	/* allocate the gate */
@@ -849,7 +849,7 @@ r9a06g032_register_dualgate(struct r9a06g032_priv *clocks,
{
	struct r9a06g032_clk_dualgate *g;
	struct clk *clk;
	struct clk_init_data init;
	struct clk_init_data init = {};

	/* allocate the gate */
	g = kzalloc(sizeof(*g), GFP_KERNEL);
+1 −1
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ struct clk * __init cpg_sd_clk_register(const char *name,
	void __iomem *base, unsigned int offset, const char *parent_name,
	struct raw_notifier_head *notifiers, bool skip_first)
{
	struct clk_init_data init;
	struct clk_init_data init = {};
	struct sd_clock *clock;
	struct clk *clk;
	u32 val;
+1 −2
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static struct clk * __init cpg_z_clk_register(const char *name,
					      const char *parent_name,
					      void __iomem *base)
{
	struct clk_init_data init;
	struct clk_init_data init = {};
	struct cpg_z_clk *zclk;
	struct clk *clk;

@@ -147,7 +147,6 @@ static struct clk * __init cpg_z_clk_register(const char *name,

	init.name = name;
	init.ops = &cpg_z_clk_ops;
	init.flags = 0;
	init.parent_names = &parent_name;
	init.num_parents = 1;

Loading