Commit f2e78aff authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: fix uninitialized symbol 'pntsd_size' 



No check for if "rc" is an error code for build_sec_desc().
This can cause problems with using uninitialized pntsd_size.

Fixes: e2f34481 ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org # v5.15
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent ef399469

fs/ksmbd/smb2pdu.c

+4 −0
Original line number Diff line number Diff line
@@ -2962,6 +2962,10 @@ int smb2_open(struct ksmbd_work *work) 
							    &pntsd_size, &fattr);

					posix_acl_release(fattr.cf_acls);

					posix_acl_release(fattr.cf_dacls);

					if (rc) {

						kfree(pntsd);

						goto err_out;

					}



					rc = ksmbd_vfs_set_sd_xattr(conn,

								    user_ns,