Commit f2dd0074 authored May 13, 2022 by Linus Torvalds

Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

Pull SCSI fixes from James Bottomley:
 "Four fixes, all in drivers.

  These patches mosly fix error legs and exceptional conditions
  (scsi_dh_alua, qla2xxx). The lpfc fixes are for coding issues with
  lpfc features"

* tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
  scsi: lpfc: Correct BDE DMA address assignment for GEN_REQ_WQE
  scsi: lpfc: Fix split code for FLOGI on FCoE
  scsi: qla2xxx: Fix missed DMA unmap for aborted commands
  scsi: scsi_dh_alua: Properly handle the ALUA transitioning state

parents c3f5e692 77526620

drivers/scsi/device_handler/scsi_dh_alua.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1172,9 +1172,8 @@ static blk_status_t alua_prep_fn(struct scsi_device sdev, struct request req)
		case SCSI_ACCESS_STATE_OPTIMAL:
		case SCSI_ACCESS_STATE_ACTIVE:
		case SCSI_ACCESS_STATE_LBA:
		return BLK_STS_OK;
		case SCSI_ACCESS_STATE_TRANSITIONING:
		return BLK_STS_AGAIN;
		return BLK_STS_OK;
		default:
		req->rq_flags \|= RQF_QUIET;
		return BLK_STS_IOERR;

drivers/scsi/lpfc/lpfc_els.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1330,7 +1330,7 @@ lpfc_issue_els_flogi(struct lpfc_vport vport, struct lpfc_nodelist ndlp,
		if (bf_get(lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) ==
		LPFC_SLI_INTF_IF_TYPE_0) {
		/* FLOGI needs to be 3 for WQE FCFI */
		ct = ((SLI4_CT_FCFI >> 1) & 1) \| (SLI4_CT_FCFI & 1);
		ct = SLI4_CT_FCFI;
		bf_set(wqe_ct, &wqe->els_req.wqe_com, ct);

		/* Set the fcfi to the fcfi we registered with */

drivers/scsi/lpfc/lpfc_sli.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -10720,10 +10720,10 @@ __lpfc_sli_prep_gen_req_s4(struct lpfc_iocbq cmdiocbq, struct lpfc_dmabuf bmp,

		/* Words 0 - 2 */
		bde = (struct ulp_bde64_le *)&cmdwqe->generic.bde;
		bde->addr_low = cpu_to_le32(putPaddrLow(bmp->phys));
		bde->addr_high = cpu_to_le32(putPaddrHigh(bmp->phys));
		bde->addr_low = bpl->addr_low;
		bde->addr_high = bpl->addr_high;
		bde->type_size = cpu_to_le32(xmit_len);
		bde->type_size \|= cpu_to_le32(ULP_BDE64_TYPE_BLP_64);
		bde->type_size \|= cpu_to_le32(ULP_BDE64_TYPE_BDE_64);

		/* Word 3 */
		cmdwqe->gen_req.request_payload_len = xmit_len;

drivers/scsi/qla2xxx/qla_target.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3826,6 +3826,9 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)

		spin_lock_irqsave(&cmd->cmd_lock, flags);
		if (cmd->aborted) {
		if (cmd->sg_mapped)
		qlt_unmap_sg(vha, cmd);

		spin_unlock_irqrestore(&cmd->cmd_lock, flags);
		/*
		* It's normal to see 2 calls in this path: