Commit f2a676d1 authored by David Howells's avatar David Howells
Browse files

rxrpc: Record statistics about ACK types 



Record statistics about the different types of ACKs that have been
transmitted and received and the number of ACKs that have been filled out
and transmitted or that have been skipped.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
parent b0154246

net/rxrpc/ar-internal.h

+6 −0
Original line number Diff line number Diff line
@@ -101,6 +101,12 @@ struct rxrpc_net { 
	atomic_t		stat_rx_data;

	atomic_t		stat_rx_data_reqack;

	atomic_t		stat_rx_data_jumbo;



	atomic_t		stat_tx_ack_fill;

	atomic_t		stat_tx_ack_send;

	atomic_t		stat_tx_ack_skip;

	atomic_t		stat_tx_acks[256];

	atomic_t		stat_rx_acks[256];

};



/*

net/rxrpc/call_event.c

+2 −0
Original line number Diff line number Diff line
@@ -50,6 +50,8 @@ static void __rxrpc_propose_ACK(struct rxrpc_call *call, u8 ack_reason, 
	unsigned long expiry = rxrpc_soft_ack_delay;

	s8 prior = rxrpc_ack_priority[ack_reason];



	rxrpc_inc_stat(call->rxnet, stat_tx_acks[ack_reason]);



	/* Pings are handled specially because we don't want to accidentally

	 * lose a ping response by subsuming it into a ping.

	 */

net/rxrpc/input.c

+1 −0
Original line number Diff line number Diff line
@@ -888,6 +888,7 @@ static void rxrpc_input_ack(struct rxrpc_call *call, struct sk_buff *skb) 
	trace_rxrpc_rx_ack(call, ack_serial, acked_serial,

			   first_soft_ack, prev_pkt,

			   summary.ack_reason, nr_acks);

	rxrpc_inc_stat(call->rxnet, stat_rx_acks[buf.ack.reason]);



	switch (buf.ack.reason) {

	case RXRPC_ACK_PING_RESPONSE:

net/rxrpc/output.c

+6 −1
Original line number Diff line number Diff line
@@ -83,8 +83,12 @@ static size_t rxrpc_fill_out_ack(struct rxrpc_connection *conn, 
	tmp = atomic_xchg(&call->ackr_nr_unacked, 0);

	tmp |= atomic_xchg(&call->ackr_nr_consumed, 0);

	if (!tmp && (reason == RXRPC_ACK_DELAY ||

		     reason == RXRPC_ACK_IDLE))

		     reason == RXRPC_ACK_IDLE)) {

		rxrpc_inc_stat(call->rxnet, stat_tx_ack_skip);

		return 0;

	}



	rxrpc_inc_stat(call->rxnet, stat_tx_ack_fill);



	/* Barrier against rxrpc_input_data(). */

	serial = call->ackr_serial;
@@ -253,6 +257,7 @@ int rxrpc_send_ack_packet(struct rxrpc_call *call, bool ping, 
	if (ping)

		rtt_slot = rxrpc_begin_rtt_probe(call, serial, rxrpc_rtt_tx_ping);



	rxrpc_inc_stat(call->rxnet, stat_tx_ack_send);

	ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len);

	conn->params.peer->last_tx_at = ktime_get_seconds();

	if (ret < 0)

net/rxrpc/proc.c

+33 −0
Original line number Diff line number Diff line
@@ -418,6 +418,33 @@ int rxrpc_stats_show(struct seq_file *seq, void *v) 
		   atomic_read(&rxnet->stat_rx_data),

		   atomic_read(&rxnet->stat_rx_data_reqack),

		   atomic_read(&rxnet->stat_rx_data_jumbo));

	seq_printf(seq,

		   "Ack      : fill=%u send=%u skip=%u\n",

		   atomic_read(&rxnet->stat_tx_ack_fill),

		   atomic_read(&rxnet->stat_tx_ack_send),

		   atomic_read(&rxnet->stat_tx_ack_skip));

	seq_printf(seq,

		   "Ack-Tx   : req=%u dup=%u oos=%u exw=%u nos=%u png=%u prs=%u dly=%u idl=%u\n",

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_REQUESTED]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_DUPLICATE]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_OUT_OF_SEQUENCE]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_EXCEEDS_WINDOW]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_NOSPACE]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_PING]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_PING_RESPONSE]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_DELAY]),

		   atomic_read(&rxnet->stat_tx_acks[RXRPC_ACK_IDLE]));

	seq_printf(seq,

		   "Ack-Rx   : req=%u dup=%u oos=%u exw=%u nos=%u png=%u prs=%u dly=%u idl=%u\n",

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_REQUESTED]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_DUPLICATE]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_OUT_OF_SEQUENCE]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_EXCEEDS_WINDOW]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_NOSPACE]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_PING]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_PING_RESPONSE]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_DELAY]),

		   atomic_read(&rxnet->stat_rx_acks[RXRPC_ACK_IDLE]));

	seq_printf(seq,

		   "Buffers  : txb=%u rxb=%u\n",

		   atomic_read(&rxrpc_n_tx_skbs),
@@ -443,5 +470,11 @@ int rxrpc_stats_clear(struct file *file, char *buf, size_t size) 
	atomic_set(&rxnet->stat_rx_data, 0);

	atomic_set(&rxnet->stat_rx_data_reqack, 0);

	atomic_set(&rxnet->stat_rx_data_jumbo, 0);



	atomic_set(&rxnet->stat_tx_ack_fill, 0);

	atomic_set(&rxnet->stat_tx_ack_send, 0);

	atomic_set(&rxnet->stat_tx_ack_skip, 0);

	memset(&rxnet->stat_tx_acks, 0, sizeof(rxnet->stat_tx_acks));

	memset(&rxnet->stat_rx_acks, 0, sizeof(rxnet->stat_rx_acks));

	return size;

}