Commit f281d010 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Corey Minyard
Browse files

ipmi: kcs_bmc: Fix a memory leak in the error handling path of 'kcs_bmc_serio_add_device()' 



In the unlikely event where 'devm_kzalloc()' fails and 'kzalloc()'
succeeds, 'port' would be leaking.

Test each allocation separately to avoid the leak.

Fixes: 3a3d2f6a ("ipmi: kcs_bmc: Add serio adaptor")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-Id: <ecbfa15e94e64f4b878ecab1541ea46c74807670.1631048724.git.christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarAndrew Jeffery <andrew@aj.id.au>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent fc4e7848

drivers/char/ipmi/kcs_bmc_serio.c

+3 −1
Original line number Diff line number Diff line
@@ -73,10 +73,12 @@ static int kcs_bmc_serio_add_device(struct kcs_bmc_device *kcs_bmc) 
	struct serio *port;



	priv = devm_kzalloc(kcs_bmc->dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	/* Use kzalloc() as the allocation is cleaned up with kfree() via serio_unregister_port() */

	port = kzalloc(sizeof(*port), GFP_KERNEL);

	if (!(priv && port))

	if (!port)

		return -ENOMEM;



	port->id.type = SERIO_8042;