Commit f25b5fae authored by Niklas Cassel's avatar Niklas Cassel Committed by Lorenzo Pieralisi
Browse files

PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is not set 



Setting a BAR size > 4 GB is invalid if PCI_BASE_ADDRESS_MEM_TYPE_64
flag is not set.

This sanity check is done in pci_epc_set_bar(), so that we don't need
to do this sanity check in all epc->ops->set_bar() implementations.

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@axis.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 3567a4ed

drivers/pci/endpoint/pci-epc-core.c

+3 −1
Original line number Diff line number Diff line
@@ -315,7 +315,9 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no, 
	    (epf_bar->barno == BAR_5 &&

	     flags & PCI_BASE_ADDRESS_MEM_TYPE_64) ||

	    (flags & PCI_BASE_ADDRESS_SPACE_IO &&

	     flags & PCI_BASE_ADDRESS_IO_MASK))

	     flags & PCI_BASE_ADDRESS_IO_MASK) ||

	    (upper_32_bits(epf_bar->size) &&

	     !(flags & PCI_BASE_ADDRESS_MEM_TYPE_64)))

		return -EINVAL;



	if (!epc->ops->set_bar)