Commit f2193bb2 authored by Xu Panda's avatar Xu Panda Committed by Helge Deller
Browse files

parisc: pdc_stable: use strscpy() to instead of strncpy() 



The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.

Signed-off-by: default avatarXu Panda <xu.panda@zte.com.cn>
Signed-off-by: default avatarYang Yang <yang.yang29@zte.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent b7bfaa76

drivers/parisc/pdc_stable.c

+3 −6
Original line number Diff line number Diff line
@@ -274,8 +274,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const char *buf, size_t coun 


	/* We'll use a local copy of buf */

	count = min_t(size_t, count, sizeof(in)-1);

	strncpy(in, buf, count);

	in[count] = '\0';

	strscpy(in, buf, count + 1);

	

	/* Let's clean up the target. 0xff is a blank pattern */

	memset(&hwpath, 0xff, sizeof(hwpath));
@@ -388,8 +387,7 @@ pdcspath_layer_write(struct pdcspath_entry *entry, const char *buf, size_t count 


	/* We'll use a local copy of buf */

	count = min_t(size_t, count, sizeof(in)-1);

	strncpy(in, buf, count);

	in[count] = '\0';

	strscpy(in, buf, count + 1);

	

	/* Let's clean up the target. 0 is a blank pattern */

	memset(&layers, 0, sizeof(layers));
@@ -756,8 +754,7 @@ static ssize_t pdcs_auto_write(struct kobject *kobj, 


	/* We'll use a local copy of buf */

	count = min_t(size_t, count, sizeof(in)-1);

	strncpy(in, buf, count);

	in[count] = '\0';

	strscpy(in, buf, count + 1);



	/* Current flags are stored in primary boot path entry */

	pathentry = &pdcspath_entry_primary;