Commit f1e1d532 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Pavel Machek
Browse files

leds: lp50xx: Put fwnode in error case during ->probe() 



fwnode_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

OTOH, the successful iteration will drop reference count under the hood, no need
to do it twice.

Fixes: 242b8117 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")
Cc: Dan Murphy <dmurphy@ti.com>
Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 807553f8

drivers/leds/leds-lp50xx.c

+1 −1
Original line number Diff line number Diff line
@@ -490,6 +490,7 @@ static int lp50xx_probe_dt(struct lp50xx *priv) 
			ret = fwnode_property_read_u32(led_node, "color",

						       &color_id);

			if (ret) {

				fwnode_handle_put(led_node);

				dev_err(priv->dev, "Cannot read color\n");

				goto child_out;

			}
@@ -512,7 +513,6 @@ static int lp50xx_probe_dt(struct lp50xx *priv) 
			goto child_out;

		}

		i++;

		fwnode_handle_put(child);

	}



	return 0;