Commit f1d97a37 authored by Yang Yingliang's avatar Yang Yingliang Committed by Stephen Boyd
Browse files

clk: mediatek: clk-pllfh: fix missing of_node_put() in fhctl_parse_dt() 



The device_node pointer returned by of_find_compatible_node() with
refcount incremented, when finish using it, the refcount need be
decreased.

Fixes: d7964de8 ("clk: mediatek: Add new clock driver to handle FHCTL hardware")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221229092946.4162345-1-yangyingliang@huawei.com


[sboyd@kernel.org: Also unmap on error]
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent d02fddf2

drivers/clk/mediatek/clk-pllfh.c

+9 −2
Original line number Diff line number Diff line
@@ -75,13 +75,13 @@ void fhctl_parse_dt(const u8 *compatible_node, struct mtk_pllfh_data *pllfhs, 
	base = of_iomap(node, 0);

	if (!base) {

		pr_err("%s(): ioremap failed\n", __func__);

		return;

		goto out_node_put;

	}



	num_clocks = of_clk_get_parent_count(node);

	if (!num_clocks) {

		pr_err("%s(): failed to get clocks property\n", __func__);

		return;

		goto err;

	}



	for (i = 0; i < num_clocks; i++) {
@@ -102,6 +102,13 @@ void fhctl_parse_dt(const u8 *compatible_node, struct mtk_pllfh_data *pllfhs, 
		pllfh->state.ssc_rate = ssc_rate;

		pllfh->state.base = base;

	}



out_node_put:

	of_node_put(node);

	return;

err:

	iounmap(base);

	goto out_node_put;

}



static void pllfh_init(struct mtk_fh *fh, struct mtk_pllfh_data *pllfh_data)