Commit f1cd6cb2 authored by Tushar Sugandhi's avatar Tushar Sugandhi Committed by Mike Snitzer
Browse files

dm ima: add a warning in dm_init if duplicate ima events are not measured 



The end-users of DM devices/targets may remove and re-create the same
device multiple times.  IMA does not measure such duplicate events if the
configuration CONFIG_IMA_DISABLE_HTABLE is set to 'n'.
To avoid confusion, the end-users need some indication on the client
if that configuration option is disabled.

Add a one-time warning during dm_init() if CONFIG_IMA_DISABLE_HTABLE
is set to 'n', to notify the end-users that duplicate events will not
be measured in the ima log. Also cleanup some whitespace in dm_init().

Signed-off-by: default avatarTushar Sugandhi <tusharsu@linux.microsoft.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 9c2adfa6

drivers/md/dm.c

+6 −3
Original line number Diff line number Diff line
@@ -262,9 +262,13 @@ static void (*_exits[])(void) = { 
static int __init dm_init(void)

{

	const int count = ARRAY_SIZE(_inits);



	int r, i;



#if (IS_ENABLED(CONFIG_IMA) && !IS_ENABLED(CONFIG_IMA_DISABLE_HTABLE))

	DMWARN("CONFIG_IMA_DISABLE_HTABLE is disabled."

	       " Duplicate IMA measurements will not be recorded in the IMA log.");

#endif



	for (i = 0; i < count; i++) {

		r = _inits[i]();

		if (r)
@@ -272,7 +276,6 @@ static int __init dm_init(void) 
	}



	return 0;



bad:

	while (i--)

		_exits[i]();