Commit f1c8781a authored by Haowen Bai's avatar Haowen Bai Committed by Jens Axboe
Browse files

s390/dasd: Use kzalloc instead of kmalloc/memset 



Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: default avatarHaowen Bai <baihaowen@meizu.com>
Reviewed-by: default avatarSven Schnelle <svens@linux.ibm.com>
Signed-off-by: default avatarStefan Haberland <sth@linux.ibm.com>
Link: https://lore.kernel.org/r/20220505141733.1989450-6-sth@linux.ibm.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent b9c10f68

drivers/s390/block/dasd_eckd.c

+1 −4
Original line number Diff line number Diff line
@@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device, 
{

	struct pe_handler_work_data *data;



	data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);

	data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);

	if (!data) {

		if (mutex_trylock(&dasd_pe_handler_mutex)) {

			data = pe_handler_worker;
@@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device, 
		} else {

			return -ENOMEM;

		}

	} else {

		memset(data, 0, sizeof(*data));

		data->isglobal = 0;

	}

	INIT_WORK(&data->worker, do_pe_handler_work);

	dasd_get_device(device);