Commit f1aa12f5 authored by Ye Guojin's avatar Ye Guojin Committed by Michael S. Tsirkin
Browse files

virtio-blk: fixup coccinelle warnings 



coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING  use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarYe Guojin <ye.guojin@zte.com.cn>
Link: https://lore.kernel.org/r/20211021065111.1047824-1-ye.guojin@zte.com.cn


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
parent ef5c366f

drivers/block/virtio_blk.c

+1 −1
Original line number Diff line number Diff line
@@ -704,7 +704,7 @@ cache_type_show(struct device *dev, struct device_attribute *attr, char *buf) 
	u8 writeback = virtblk_get_cache_mode(vblk->vdev);



	BUG_ON(writeback >= ARRAY_SIZE(virtblk_cache_types));

	return snprintf(buf, 40, "%s\n", virtblk_cache_types[writeback]);

	return sysfs_emit(buf, "%s\n", virtblk_cache_types[writeback]);

}



static DEVICE_ATTR_RW(cache_type);